feat(oss-licenses): implement dynamic embedded license detection#414
Merged
timothyfroehlich merged 4 commits intomainfrom Apr 24, 2026
Merged
feat(oss-licenses): implement dynamic embedded license detection#414timothyfroehlich merged 4 commits intomainfrom
timothyfroehlich merged 4 commits intomainfrom
Conversation
xyarco
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
oss-licenses-pluginto dynamically detect and extract embedded licenses from all AAR and JAR artifacts, removing the hardcoded reliance on specific Google Play Services or Firebase maven groups.Key changes
isGoogleServicesandisGranularVersionchecks with a universal "bundled license" check. The task now attempts to unzip every resolved artifact to look forthird_party_licenses.jsonandthird_party_licenses.txt.*-license) to skip POM license extraction for side-car artifacts while still extracting their embedded data, preventing redundant attribution entries.addEmbeddedLicensesto usetry-with-resourcesforZipFilehandling and added error catching for malformed or non-ZIP artifacts to ensure build stability.GOOGLE_PLAY_SERVICES_GROUP,FIREBASE_GROUP, etc.) and internal methods related to legacy group-based branching.Test plan
action_nonGmsGranularLibrary_extractsTransitiveLicensesunit test for non-GMS granular licenses.action_licenseSidecarArtifact_skipsPomButExtractsEmbeddedunit test for the-licenseside-car path.